Refactor splice interpreter #16280
Merged
Refactor splice interpreter #16280
+385
−333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
refactor-splice-interpreter
branch
from
f94710c to
05303a9
Compare
smarter
requested changes
Nov 14, 2022
| import dotty.tools.repl.AbstractFileClassLoader | ||
|
|
||
|
|
||
| /** List of classes of the parameters of the signature of `sym` */ |
There was a problem hiding this comment.
That comment seems misplaced? It also appears above def paramsSig
There was a problem hiding this comment.
Removed. I must have pasted it by mistake.
|
|
||
| type Env = Map[Symbol, Object] | ||
|
|
||
| /** Returns the interpreted result of interpreting the code a call to the symbol with default arguments. |
There was a problem hiding this comment.
Looks like this comment was here before but I'm having trouble interpreting it myself :). Is there a word missing around "the code a call", should it be "the code of a call" ?
There was a problem hiding this comment.
I rewrote the sentence.
Extract the general purpose logic from the splice interpreter. The new interpreter class will be the basis for the macro annotation interpreter. The splice interpreter only keeps logic related with level -1 quote and type evaluation. Part of https://github.com/dotty-staging/dotty/tree/design-macro-annotations
nicolasstucki
force-pushed
the
refactor-splice-interpreter
branch
from
05303a9 to
ee51648
Compare
smarter
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract the general purpose logic from the splice interpreter. The new interpreter class will be the basis for the macro annotation interpreter. The splice interpreter only keeps logic related with level -1 quote and type evaluation.
Part of https://github.com/dotty-staging/dotty/tree/design-macro-annotations