Skip to content

Add error message - Parsers.scala:695 #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Add error message - Parsers.scala:695 #1628

merged 1 commit into from
Oct 25, 2016

Conversation

AndrewZurn
Copy link
Contributor

Adds error message for by-name parameters. #1589

@felixmulder
Copy link
Contributor

Hey @AndrewZurn - sign the CLA plz: https://www.lightbend.com/contribute/cla/scala

@AndrewZurn
Copy link
Contributor Author

@felixmulder just did, should update after tests pass (hopefully).

Copy link
Contributor

@felixmulder felixmulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM :)

|allowing for lazy evaluation of a parameter.
|
|An example of using a by-name parameter would look like:
|${"def func(f: => Boolean) = f"} // 'f' is evaluated when it is referenced within the function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move the } to the end of the line so the full line is highlighted (and I'd cut out "it is" so that the line doesn't exceed 80 columns)

@AndrewZurn
Copy link
Contributor Author

@felixmulder should be good to go now

@felixmulder felixmulder merged commit 0ab1217 into scala:master Oct 25, 2016
@felixmulder
Copy link
Contributor

Great, thanks @AndrewZurn!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants