Skip to content

Fix #1576: Parameters of Java annotations should be public #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 13, 2016

Parameters of annotation classes parsed by the Java parser should
have public val parameters. Otherwise they cannot be accessed as fields.

Fixes #1576. Review by @OlivierBlanvillain

Parameters of annotation classes parsed by the Java parser should
have public val parameters. Otherwise they cannot be accessed as fields.
Copy link
Contributor

@OlivierBlanvillain OlivierBlanvillain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OlivierBlanvillain OlivierBlanvillain merged commit 3e76f3c into scala:master Oct 20, 2016
@allanrenucci allanrenucci deleted the fix-#1576 branch December 14, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants