Support Mirror synthesis for local and inner classes #15847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update child accessibility check for anonymous mirrors in whyNotGenericSum. Now check the prefix at the callsite can access the child. - for sum mirrors, compute a new prefix for each child from the callsite prefix of the parent, see TypeOps.childPrefix. For each child, subsititute its prefix at definition with the childPrefix using asSeenFrom. For polymorphic classes, perform the subsitution on the constructor before inferring constraints. - add tests for issues 13332, 13935, 11174, 12328 - add tests for local/inner classes taken from Shapeless for its Generic type, backed by mirrors
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/15847/ to see the changes. Benchmarks is based on merging with main (e560c2d) |
dwijnand
approved these changes
Aug 15, 2022
|
should this be back ported to 3.2.0 - e.g. 3.2.0 won't be able to summon a mirror for a local class compiled by 3.2.1, so that makes it a forward source compatibility breaking change |
bishabosha
added
the
backport:nominated
|
doing the backport PR now |
Kordyjan
added
backport:done
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new PR which takes a simpler approach - compute a prefix for the child and use
asSeenFromalso added documentation changes
fixes #13332
fixes #12328
fixes #11174
fixes #13935
fixes #15122