Fix Vulpix progress vs sbt supershell (CR) #15623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
reviewed
Jul 8, 2022
som-snytt
reviewed
Jul 8, 2022
som-snytt
reviewed
Jul 8, 2022
It seems how things are done by putting a carriage return at the end doesn't play nicely with sbt's super shell. And I couldn't find a way to disable supershell during test execution. So instead I found that carriage returning at the start seems to work as desired. Other that that I just cleaned up the area a bit (subjectively).
som-snytt
approved these changes
Jul 9, 2022
|
Didn't work for me with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems how things are done by putting a carriage return at the end
doesn't play nicely with sbt's super shell. And I couldn't find a way
to disable supershell during test execution. So instead I found that
carriage returning at the start seems to work as desired.
Other that that I just cleaned up the area a bit (subjectively).
[test_non_bootstrapped]