Improve message when directory is passed dotc. #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
reviewed
Oct 9, 2016
| @@ -30,7 +30,7 @@ object Formatting { | |||
| catch { | |||
| case NonFatal(ex) => s"[cannot display due to $ex, raw string = $toString]" | |||
| } | |||
| case _ => arg.toString | |||
| case _ => s"$arg" | |||
There was a problem hiding this comment.
Is this related/relevant to the PR?
There was a problem hiding this comment.
It does not look like it - @olafurpg, could you remove this from the PR?
There was a problem hiding this comment.
The NPE that triggered this PR originated from arg being null so I wrapped it into quasiquotes.
There was a problem hiding this comment.
I see, however, I still don't think we should be allowing null.show.
There was a problem hiding this comment.
It's arguably better if this blows up :)
There was a problem hiding this comment.
Fine, I've removed the change.
felixmulder
suggested changes
Oct 10, 2016
| @@ -30,7 +30,7 @@ object Formatting { | |||
| catch { | |||
| case NonFatal(ex) => s"[cannot display due to $ex, raw string = $toString]" | |||
| } | |||
| case _ => arg.toString | |||
| case _ => s"$arg" | |||
There was a problem hiding this comment.
It does not look like it - @olafurpg, could you remove this from the PR?
felixmulder
approved these changes
Oct 10, 2016
Previously, running ./bin/dotc <directory> caused a null pointer exception. Now, the error is: error: expected file, received directory 'bin'
|
I've rebased now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running ./bin/dotc caused a null pointer
exception. Now, the error is:
error: expected file, received directory <directory>