Add test of pickling positions under -Ytest-pickler #1541
Conversation
|
/rebuild |
1 similar comment
|
/rebuild |
|
@SethTisue : All of our recent PRs are failing in Jenkins with: [warn] ::::::::::::::::::::::::::::::::::::::::::::::
sbt.ResolveException: download failed: org.scala-sbt#main;0.13.11!main.jar
download failed: org.scala-sbt#actions;0.13.11!actions.jar
download failed: org.scala-sbt#io;0.13.11!io.jar
download failed: org.scala-sbt#completion;0.13.11!completion.jar
download failed: org.scala-sbt#collections;0.13.11!collections.jar
download failed: org.scala-sbt#api;0.13.11!api.jar
download failed: org.scala-sbt#incremental-compiler;0.13.11!incremental-compiler.jar
download failed: org.scala-sbt#compile;0.13.11!compile.jar
download failed: org.scala-sbt#ivy;0.13.11!ivy.jar
download failed: org.scala-sbt#main-settings;0.13.11!main-settings.jar
download failed: org.scala-sbt#command;0.13.11!command.jar
download failed: org.scala-sbt#compiler-interface;0.13.11!compiler-interface.jarAny idea what's going on? |
|
@smarter I saw some errors like that in some Scala builds yesterday too, but they stopped — probably some transient problem with bintray? if rebuilding today doesn't make them go away, let me know |
|
/rebuild |
|
@SethTisue Looks like it's still broken: https://scala-ci.typesafe.com/job/dotty-master-validate-partest/2197/console |
|
@eed3si9n these are sbt jars on repo.typesafe.com. do we want to report this somewhere, either within Lightbend, or to Bintray? |
|
@eed3si9n here's an example from a Scala job yesterday: https://scala-ci.typesafe.com/view/scala-2.12.0/job/scala-2.12.0-integrate-bootstrap/113/console |
[warn] [FAILED ] org.scala-sbt#compiler-interface;0.13.11!compiler-interface.jar:
The HTTP response code for https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/compiler-interface/0.13.11/jars/compiler-interface.jar
did not indicate a success. See log for more detail. (648ms)And yet this works locally: % wget https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/compiler-interface/0.13.11/jars/compiler-interface.jar
--2016-09-28 17:21:29-- https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/compiler-interface/0.13.11/jars/compiler-interface.jar
Resolving repo.typesafe.com (repo.typesafe.com)... 52.203.61.63, 54.165.237.90
Connecting to repo.typesafe.com (repo.typesafe.com)|52.203.61.63|:443... connected.
HTTP request sent, awaiting response... 302 Moved Temporarily
Location: https://dl.bintray.com/typesafe/ivy-releases/org.scala-sbt/compiler-interface/0.13.11/jars/compiler-interface.jar [following]
--2016-09-28 17:21:30-- https://dl.bintray.com/typesafe/ivy-releases/org.scala-sbt/compiler-interface/0.13.11/jars/compiler-interface.jar
Resolving dl.bintray.com (dl.bintray.com)... 5.153.35.248
Connecting to dl.bintray.com (dl.bintray.com)|5.153.35.248|:443... connected.
HTTP request sent, awaiting response... 302
Location: https://akamai.bintray.com/9a/9aac6cd27c09179722d2b8c680cff03da1754c8ed0d96d7778c4f0c64cfc470f?__gda__=exp=1475076811~hmac=0f39fe43c92c3f0915cfb9c4741f9819131f2b71131009adba22ef111bc4772e&response-content-disposition=attachment%3Bfilename%3D%22compiler-interface.jar%22&response-content-type=application%2Fjava-archive&requestInfo=U2FsdGVkX19nGVdF15P4uKviB5l_MHrcI5HCKRixmgV35Bqc317SAf1Yp8nOWrZfKfZkHzFyxjxek4E_bu3bwvle_IsidSWTwwnwxrNrpxOE7fOarQy5iM4x1yw4EyG9wR5gU9n5faNfQTjKVf0BF4DOvQ9yXJCcEJr45vH3jXU [following]
--2016-09-28 17:21:31-- https://akamai.bintray.com/9a/9aac6cd27c09179722d2b8c680cff03da1754c8ed0d96d7778c4f0c64cfc470f?__gda__=exp=1475076811~hmac=0f39fe43c92c3f0915cfb9c4741f9819131f2b71131009adba22ef111bc4772e&response-content-disposition=attachment%3Bfilename%3D%22compiler-interface.jar%22&response-content-type=application%2Fjava-archive&requestInfo=U2FsdGVkX19nGVdF15P4uKviB5l_MHrcI5HCKRixmgV35Bqc317SAf1Yp8nOWrZfKfZkHzFyxjxek4E_bu3bwvle_IsidSWTwwnwxrNrpxOE7fOarQy5iM4x1yw4EyG9wR5gU9n5faNfQTjKVf0BF4DOvQ9yXJCcEJr45vH3jXU
Resolving akamai.bintray.com (akamai.bintray.com)... 104.99.161.109
Connecting to akamai.bintray.com (akamai.bintray.com)|104.99.161.109|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 250237 (244K) [application/java-archive]
Saving to: ‘compiler-interface.jar’
compiler-interface.jar 100%[======================================================================================================================>] 244,37K --.-KB/s in 0,1s
2016-09-28 17:21:31 (2,02 MB/s) - ‘compiler-interface.jar’ saved [250237/250237]I wish I knew where these mysterious logs containing "more details" that the error message refers to were so that I could look at them. |
|
@SethTisue Can you ssh on the machine and wget a jar from the repo? |
|
Looks like https://scala-ci.typesafe.com/job/dotty-master-validate-junit/2194/console managed to download everything so the issue may be hard to reproduce |
|
@SethTisue I've been noticing Travis is having problem getting sbt artifacts too. I opened sbt/sbt#2758 to track this. |
|
/rebuild |
OlivierBlanvillain
force-pushed
the
test-pickling-positions
branch
from
e275b7c to
568ed18
Compare
|
Inline has been merged so you should be able to just rebase on master |
OlivierBlanvillain
force-pushed
the
test-pickling-positions
branch
2 times, most recently
from
ed7aeeb to
828b2c5
Compare
This reverts commit ed7aeeb. Conflicts: src/dotty/tools/dotc/transform/Pickler.scala
OlivierBlanvillain
force-pushed
the
test-pickling-positions
branch
from
828b2c5 to
b6df675
Compare
|
@smarter following your suggestion I've changed what I did to instead compare pretty printer trees with positions. This revealed that many nodes are unpickled with |
|
/rebuild |
This PR adds a test under
-Ytest-picklerto verify thatPosition#startandPosition#endare identical before and after pickling.Position#pointis ignored as it's not pickled.@smarter could you have a look?