Signature help fixes for exposed bugs and refactor after signature change #15278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
commented
May 24, 2022
tgodzik
requested changes
May 24, 2022
language-server/test/dotty/tools/languageserver/SignatureHelpTest.scala
Outdated
Show resolved
Hide resolved
tgodzik
reviewed
Jun 2, 2022
language-server/test/dotty/tools/languageserver/SignatureHelpTest.scala
Outdated
Show resolved
Hide resolved
language-server/test/dotty/tools/languageserver/SignatureHelpTest.scala
Outdated
Show resolved
Hide resolved
tgodzik
approved these changes
Jun 10, 2022
dos65
pushed a commit
to dos65/metals
that referenced
this pull request
Jun 17, 2022
See: scala/scala3#15278 `Signatures.callInfo` was deprecated and we should use `Signatures.signatureHelp`
dos65
pushed a commit
to dos65/metals
that referenced
this pull request
Jun 17, 2022
See: scala/scala3#15278 `Signatures.callInfo` was deprecated and we should use `Signatures.signatureHelp`
dos65
pushed a commit
to scalameta/metals
that referenced
this pull request
Jun 17, 2022
See: scala/scala3#15278 `Signatures.callInfo` was deprecated and we should use `Signatures.signatureHelp`
bishabosha
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Oct 18, 2022
…ange (scala#15278) * add deleted methods as depreceted one * add type parameter inference for apply methods * change signatureHelp method signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15248
Fixes #15244
Fixes #15284
For all found bugs i created tests.
This pull request changes almost whole file, as in previous implementation I tried to leave function signature the way it was.
It required few hacks to achieve that but now I've hit the wall and to fix:
I had to change function signature as I discussed it with @tgodzik. As i changed signature, many places became unreadable and I had to refactor it a bit thus so many lines are changed. I could try split it into multiple pull requests but effect would be almost the same as it changed almost all file. I will pinpoint locations which caused each bug to where it was fixed.
I also wrote documentation for new functions to better explain the idea.