Disallow @targetName on top-level class, trait, and object
#15068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup some leftovers from when `@targetName` was called `@alpha`.
This comment was marked as outdated.
This comment was marked as outdated.
This usage was mostly broken, as it failed with separate compilation.
griggt
force-pushed
the
disallow-targetname-on-toplevel-classes
branch
from
6888f09 to
47189c7
Compare
smarter
approved these changes
May 4, 2022
som-snytt
reviewed
May 4, 2022
| @@ -176,7 +176,8 @@ enum ErrorMessageID extends java.lang.Enum[ErrorMessageID]: | |||
| MatchableWarningID, | |||
| CannotExtendFunctionID, | |||
| LossyWideningConstantConversionID, | |||
| ImplicitSearchTooLargeID | |||
| ImplicitSearchTooLargeID, | |||
| TargetNameOnTopLevelClassID | |||
There was a problem hiding this comment.
Does anyone else feel the need for an end marker, and also trailing comma before end marker?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This usage was mostly broken, as it failed with separate compilation.
Closes #15066