Scaladoc: add extension suffixes and fqName to scaladoc searchbar #15048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pikinier20
approved these changes
Apr 28, 2022
| div(cls := "scaladoc-searchbar-row monospace", "result" := "")( | ||
| a(href := location)( | ||
| p.fullName, | ||
| span(cls := "italic")(extensionTargetMessage), |
There was a problem hiding this comment.
Could be just:
span(i(extensionTargetMessage))
Then, you wouldn't need to add CSS rule to make the text italic.
Extension suffixes in the form of italized 'extension on (...)' allow to separate semantically different methods, which previously would have been displayed as the same in searchbar. File-based location was also replaced with fully qualified name based, in an effort to improve readability.
jchyb
force-pushed
the
scaladoc/fix-searchbar-repeating
branch
from
c79f586 to
9e1f5a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suffixes in the form of italic extension on (...) for extension defs will allow to separate semantically different methods, which previously would have been displayed as the same in searchbar.
File-based location was also replaced with fully qualified name based, in an effort to improve overall readability.
Fixes #14486
Can be viewed on: https://scala3doc.virtuslab.com/pr-fix-searchbar-repeating/scala3/index.html