Relax assertion in TyperState#commit If there's nothing to commit; clear unreported warnings in Reporter#flush #15037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the added test case is run with `-Yforce-sbt-phases`, a LazyRef (created in the LazyRef case of TypeMap#mapOver) captures a Context. Later, that LazyRef is forced, but at that point the TyperState of the captured Context is already committed, so we're not allowed to commit anything in it anymore. But forcing the LazyRef ends up calling `isFullyDefined` which unconditionally creates a temporary TyperState and commit it, thus triggering the assertion. We fix this by relaxing the assertion to allow committing into a TyperState if there's nothing to commit. This should handle all LazyRefs since they never wrap uninstantiated type variables in practice. Fixes scala#14907.
odersky
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.