Skip to content

Revert "Remove support -scala-output-version with quotes" #14991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Apr 21, 2022

This reverts commit ca01392.

Fixes #14989

[test_forward_compat]

This reverts commit ca01392.

Fixes scala#14989

[test_forward_compat]
@nicolasstucki nicolasstucki marked this pull request as ready for review April 21, 2022 07:00
@nicolasstucki
Copy link
Contributor Author

We add the -scala-output-version functionality only to make the test_forward_compat pass. When we remove the -scala-output-version we should re-revert this change.

@Kordyjan
Copy link
Contributor

I think that we can disable test_forward_compat right now. 3.1.3 will be the last version to support the -scala-output-version flag, which is already branched from the main. Those tests are useless for us as of now.

@Kordyjan
Copy link
Contributor

Alternative fix: #14995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly Dotty workflow of 2022-04-21 failed
2 participants