Revise duplicate diagnostics logic #14845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic that hid duplicate messages was fragile and overly aggressive. - Because of mixin ordering, it could be that a non-sensical message that was in the end not reported could prevent a message at overlapping positions to be hidden. This could mean that no errors at all were reported even through the program was erroneous. - A message that ended up to be hidden since it overlapped with another message could still hide further messages with which it overlapped as well. Fixing the logic meant that some tests have more error messages reported. Fixes scala#14834 Fixes scala#12457
dwijnand
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic that hid duplicate messages was fragile and overly aggressive.
in the end not reported could prevent a message at overlapping positions
to be hidden. This could mean that no errors at all were reported even
through the program was erroneous.
could still hide further messages with which it overlapped as well.
Fixing the logic meant that some tests have more error messages reported.
Fixes #14834
Fixes #12457