Fix SymDenot.isStatic & isStaticOwner after lambdaLift. #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other approach would be to actually check for presence of $outer field after lambda lift, but I'd prefer not to rely on side-effects here
|
I don't think this is in the right spirit of things. "isStatic" is a property of denotations. When things get moved out to package level by flatten, they are thereby made static. We should not try to dissimulate this. So we need to work at the caller. Either ask whether the denotation was static before flatten and lambda lift, or indeed look at an outer field. |
|
Superseded by #1477. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other approach would be to actually check for presence of $outer
field after lambda lift, but I'd prefer not to rely on side-effects here