-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: update links to point to Scala site #14520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This just updates some of the links in the README that are still linking to the old Dotty site. This updates them to point towards the new documentation located on the actual Scala site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any thoughts on adding a smalls section about code style in here? My first pr I sent in I was working in code of all shapes and sizes, some with significant whitespace, some not, etc. Should all new code be using signification whitespace? If so, should I put that in here?
6. After the review, you should resolve issues brought up by the reviewers as needed (pushing a new commit to address reviewers' comments), iterating until the reviewers give their thumbs up, the "LGTM" (acronym for "Looks Good To Me"). | ||
7. Once the code has passed review the Pull Request can be merged into the distribution. | ||
|
||
## Pull Request Requirements | ||
|
||
First, please have a look at and follow the [Pull Request Policy](https://github.com/scala/scala/wiki/Pull-Request-Policy) for guidelines on submitting a pull request to the dotty project. (the pull request policy is the same as for the Scala programming language) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, this doesn't exist anymore as the link just now redirects to the Scala github. Has this been moved somewhere else? If not I just removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SethTisue maybe you know what has happened with https://github.com/scala/scala/wiki/Pull-Request-Policy ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scala/scala hasn't had a wiki in yeeeeeeeeeears, so that link must be super ancient
we merged the content into README.md and/or CONTRIBUTING.md, e.g at scala/scala@1978456
but in a Scala 3 context, it probably doesn't make sense to direct anybody to either of those files wholesale. but feel free to copy-and-paste anything you'd like to steal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no objection, I could merge this PR as it is and copy some interesting paragraphs from scala/scala later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! That's fine by me.
This just updates some of the links in the README that are still linking
to the old Dotty site. This updates them to point towards the new
documentation located on the actual Scala site.