Skip to content

docs: update links to point to Scala site #14520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Feb 19, 2022

This just updates some of the links in the README that are still linking
to the old Dotty site. This updates them to point towards the new
documentation located on the actual Scala site.

This just updates some of the links in the README that are still linking
to the old Dotty site. This updates them to point towards the new
documentation located on the actual Scala site.
Copy link
Member Author

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any thoughts on adding a smalls section about code style in here? My first pr I sent in I was working in code of all shapes and sizes, some with significant whitespace, some not, etc. Should all new code be using signification whitespace? If so, should I put that in here?

6. After the review, you should resolve issues brought up by the reviewers as needed (pushing a new commit to address reviewers' comments), iterating until the reviewers give their thumbs up, the "LGTM" (acronym for "Looks Good To Me").
7. Once the code has passed review the Pull Request can be merged into the distribution.

## Pull Request Requirements

First, please have a look at and follow the [Pull Request Policy](https://github.com/scala/scala/wiki/Pull-Request-Policy) for guidelines on submitting a pull request to the dotty project. (the pull request policy is the same as for the Scala programming language)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this doesn't exist anymore as the link just now redirects to the Scala github. Has this been moved somewhere else? If not I just removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala/scala hasn't had a wiki in yeeeeeeeeeears, so that link must be super ancient

we merged the content into README.md and/or CONTRIBUTING.md, e.g at scala/scala@1978456

but in a Scala 3 context, it probably doesn't make sense to direct anybody to either of those files wholesale. but feel free to copy-and-paste anything you'd like to steal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's no objection, I could merge this PR as it is and copy some interesting paragraphs from scala/scala later

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! That's fine by me.

@TheElectronWill TheElectronWill merged commit c1071d6 into scala:main Feb 28, 2022
@ckipp01 ckipp01 deleted the docUpdates branch March 1, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants