Supress safe initialization warning in Run class #14465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Feb 13, 2022
|
I've put together an alternative fix here. If we decide that the other fix is good, I will close this PR. |
Due to the `this` pointer being passed to `start.setRun` in a function called during initialization, the initialization checker cannot prove that `this` is fully initialized.
We would get the following error:
```
[error] -- Error: /*******/dotty/compiler/src/dotty/tools/dotc/Run.scala:84:17
[error] 84 | start.setRun(this)
[error] | ^^^^
[error] |Cannot prove that the value is fully initialized. Only initialized values may be used as arguments. Calling trace:
[error] | -> val run = new Run(this, initCtx) { [ ReplCompiler.scala:42 ]
[error] | -> class Run(comp: Compiler, ictx: Context) extends ImplicitRunInfo with ConstraintRunInfo {iler-b[ Run.scala:38 ]
[error] | -> private var myCtx = rootContext(using ictx) [ Run.scala:89 ]
[error] | -> val rootCtx = super.rootContext.fresh [ ReplCompiler.scala:62 ]
```
The call to `start.setRun` stores the reference to `this` in a store without accessing any of its fields. The instance of `Run` referrred to by `this` will be fully initialized immediately after that function call. Thus, we are able to safely mark `this` as `@unchecked` without worrying about uninitialized members of the `Run` instance being accessed.
Review by @liufengyun
Xavientois
force-pushed
the
fix-setRun-safe-init-warning
branch
from
413180a to
3138600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the
thispointer being passed tostart.setRunin a function called during initialization, the initialization checker cannot prove thatthisis fully initialized.We would get the following error:
The call to
start.setRunstores the reference tothisin a store without accessing any of its fields. The instance ofRunreferrred to bythiswill be fully initialized immediately after that function call. Thus, we are able to safely markthisas@uncheckedwithout worrying about uninitialized members of theRuninstance being accessed.Review by @liufengyun