Skip to content

migrate gitter links to discord #14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2022
Merged

migrate gitter links to discord #14211

merged 1 commit into from
Jan 4, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Jan 4, 2022

This follows up the announcement made on https://www.scala-lang.org/blog/2021/12/21/discord.html
that Discord is now the official Scala chat.

@smarter
Copy link
Member

smarter commented Jan 4, 2022

There's also the "join chat" gitter button on the front page: https://github.com/lampepfl/dotty/blob/master/docs/_layouts/main.html (and I see references to gitter in css files that could be deleted with that too)

This follows up the announcement made on https://www.scala-lang.org/blog/2021/12/21/discord.html
that Discord is now the official Scala chat.
@ckipp01
Copy link
Member Author

ckipp01 commented Jan 4, 2022

There's also the "join chat" gitter button on the front page: https://github.com/lampepfl/dotty/blob/master/docs/_layouts/main.html (and I see references to gitter in css files that could be deleted with that too)

Good catch, I removed a bunch more stuff although I have no idea where that gitter pop out happens. Clicking around and looking at the current site I have no idea where that happens. Am I missing it somewhere? For now I just removed all the gitter stuff.

@smarter
Copy link
Member

smarter commented Jan 4, 2022

On http://dotty.epfl.ch/docs/ on the right there is a "OPEN CHAT" button vertically.

@smarter smarter enabled auto-merge January 4, 2022 19:11
@ckipp01
Copy link
Member Author

ckipp01 commented Jan 4, 2022

On http://dotty.epfl.ch/docs/ on the right there is a "OPEN CHAT" button vertically.

Ahh pff of course I glazed right over it. 👍🏼 thanks

@smarter smarter merged commit 1e6f00b into scala:master Jan 4, 2022
@ckipp01 ckipp01 deleted the discord branch January 4, 2022 21:04
@smarter
Copy link
Member

smarter commented Jan 5, 2022

Hmm the discord logo is huge: http://dotty.epfl.ch/docs/

@ckipp01
Copy link
Member Author

ckipp01 commented Jan 5, 2022

Hmm the discord logo is huge: http://dotty.epfl.ch/docs/

Really? What are you seeing? I'm seeing:

Firefox

Screenshot 2022-01-05 at 18 37 11

Chrome

Screenshot 2022-01-05 at 18 35 01

Mobile

Screenshot 2022-01-05 at 18 35 51

@SethTisue
Copy link
Member

SethTisue commented Jan 5, 2022

perhaps it simply appears large to Guillaume because he finds it threatening ;-)

it's normal size for me in Safari

@smarter
Copy link
Member

smarter commented Jan 5, 2022

In firefox (chrome looks fine):
Screenshot_20220105_184339
I use 2x scaling (that is, window.devicePixelRatio returns 2), don't know if that's related.

@ckipp01
Copy link
Member Author

ckipp01 commented Jan 5, 2022

I have no idea. I've been playing around trying to mimic this on firefox and I cant.
Screenshot 2022-01-05 at 20 17 30

What version of Firefox are you using?

@smarter
Copy link
Member

smarter commented Jan 5, 2022

I'm using firefox developer edition (the beta branch) at version 96.0b10. If we can't figure out we could just resize the social icons to all be the same 32x32 size?

@ckipp01
Copy link
Member Author

ckipp01 commented Jan 5, 2022

I'm using firefox developer edition (the beta branch) at version 96.0b10. If we can't figure out we could just resize the social icons to all be the same 32x32 size?

They are already set in the css as

.social-icon img {
  height: 20px;
  width: 20px;
}

@smarter
Copy link
Member

smarter commented Jan 5, 2022

Oh, I figured it out, I use an adblocker and it has a rule that ends up blocking social-links.css 😓. So we could rename that file to not contain the word "social" or anything else in https://secure.fanboy.co.nz/fanboy-annoyance.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants