Implement Xprint-diff without external libraries. #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolasstucki Can you propose a reviewer? |
|
Review by @DarkDimius |
nicolasstucki
force-pushed
the
fix-output-diff
branch
from
e184f26 to
dcf93a0
Compare
|
BTW, I found some bugs with the current implementation. I did not try to minimize them and add them to the issue tracker because this PR fixes them. |
| val insert = F(i)(j - 1) + d | ||
| F(i)(j) = mtch max insert max delete | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not use Array.tabulate rather than Array.fill?
There was a problem hiding this comment.
It was to remain as close as possible to the pseudocode of the algorithm. I will change it now to save up two small traversals.
nicolasstucki
force-pushed
the
fix-output-diff
branch
2 times, most recently
from
d024f46 to
f2893c4
Compare
|
Can this go in now? |
nicolasstucki
force-pushed
the
fix-output-diff
branch
from
f2893c4 to
606ae57
Compare
|
I should be ready to go in. In the last update I just changed a couple of variable names that Codacy suggested and I completely agreed with it in those cases. |
nicolasstucki
force-pushed
the
fix-output-diff
branch
from
606ae57 to
32c532e
Compare
nicolasstucki
force-pushed
the
fix-output-diff
branch
from
32c532e to
c3c796f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.