Fix #1284: Make classTag depend directly on erasure #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the end, a classTag reflects the erased version of a type. The only condition for its generation should be that the erasure is stable under possible instantiations.
|
Review by @xeno-by ? |
| return ref(defn.ClassTagModule) | ||
| .select(nme.apply) | ||
| .appliedToType(tp) | ||
| .appliedTo(clsOf(erasure(tp))) |
There was a problem hiding this comment.
That's an interesting DSL! Does it cover the entire language, or it just contains a few most used utilities?
There was a problem hiding this comment.
It covers about 30 ops, maybe half of them construct syntax trees. See ast.tpd#TreeOps for where it is defined.
|
To the best of my knowledge, lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the end, a classTag reflects the erased version of a type. The only
condition for its generation should be that the erasure is stable under
possible instantiations.