Fix parameterized typedefs with lambdas as rhs #1409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the compiler crashed when faced with a parameterized typedef that has a lambda as rhs. We fix this by refining the condition when not to abstract in typeDefsig.
| val rhsType = abstracted(typedAheadType(tdef.rhs).tpe) | ||
|
|
||
| val isDerived = tdef.rhs.isInstanceOf[untpd.DerivedTypeTree] | ||
| val rhsType = abstracted(typedAheadType(tdef.rhs).tpe, canAbstract = !isDerived) |
There was a problem hiding this comment.
Having a boolean parameter that changes the behavior of a method to become the identity seems weird to me, I would just write:
val rhsType0 = typedAheadType(tdef.rhs).tpe
val rhsType = if (!isDerived) abstracted(rhsType0) else rhsType0
|
If we're going to support that, we should also support multiple application, |
Adapt operations TypeApplications and TypeComparer to account for the possibilities of curried type lambdas.
As @smarter noted, makes no sense to use a boolean parameter here. We got there by refactoring blindness.
|
@smarter Last two commits should address your comments. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the compiler crashed when faced with a parameterized typedef
that has a lambda as rhs. We fix this by refining the condition when
not to abstract in typeDefsig.
Review by @smarter