Skip to content

Add spire to community build #13788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Add spire to community build #13788

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6310b35
Add spire to community build
armanbilge Oct 21, 2021
de9728d
Remove algebra from spire deps
armanbilge Oct 21, 2021
b86fe0f
Poke ci
armanbilge Nov 1, 2021
c4462a7
Merge branch 'master' into topic/spire
armanbilge Nov 17, 2021
8b8778b
Use dotty-staging repo
armanbilge Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,3 +216,6 @@
[submodule "community-build/community-projects/specs2"]
path = community-build/community-projects/specs2
url = https://github.com/dotty-staging/specs2.git
[submodule "community-build/community-projects/spire"]
path = community-build/community-projects/spire
url = https://github.com/typelevel/spire.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url = https://github.com/typelevel/spire.git
url = https://github.com/dotty-staging/spire.git

As a rule we use links to forks instead of original repos to ensure reproducibility of builds from the compiler's perspective (if the main branch of the community project repo changes, possibly making the community build fail, but the compiler's master doesn't change then master's build should still succeed if it succeeded earlier).
I created the fork so this should work with the suggested change

1 change: 1 addition & 0 deletions community-build/community-projects/spire
Open in desktop
Submodule spire added at c98b32
9 changes: 8 additions & 1 deletion community-build/src/scala/dotty/communitybuild/projects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,14 +730,21 @@ object projects:
sbtPublishCommand = "publishLocal",
dependencies = List(scalaJava8Compat, scalatest)
)

lazy val specs2 = SbtCommunityProject(
project = "specs2",
sbtTestCommand = "core/testOnly -- exclude ci",
sbtPublishCommand = "core/publishLocal",
dependencies = List()
)

lazy val spire = SbtCommunityProject(
project = "spire",
sbtTestCommand = "test",
sbtPublishCommand = "publishLocal",
dependencies = List(cats, disciplineMunit)
)

end projects

def allProjects = List(
Expand Down
1 change: 1 addition & 0 deletions community-build/test/scala/dotty/communitybuild/CommunityBuildTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ class CommunityBuildTestC:
@Test def scas = projects.scas.run()
@Test def sconfig = projects.sconfig.run()
@Test def shapeless = projects.shapeless.run()
@Test def spire = projects.spire.run()
@Test def sourcecode = projects.sourcecode.run()
@Test def specs2 = projects.specs2.run()
@Test def stdLib213 = projects.stdLib213.run()
Expand Down