Skip to content

Make distinctRefs in ImportSuggestions use constant stackspace #13667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Make distinctRefs in ImportSuggestions use constant stackspace #13667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions compiler/src/dotty/tools/dotc/typer/ImportSuggestions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,11 +273,14 @@ trait ImportSuggestions:
/** The `ref` parts of this list of pairs, discarding subsequent elements that
* have the same String part. Elements are sorted by their String parts.
*/
extension (refs: List[(TermRef, String)]) def distinctRefs(using Context): List[TermRef] = refs match
case (ref, str) :: refs1 =>
ref :: refs1.dropWhile(_._2 == str).distinctRefs
case Nil =>
Nil
extension (refs: List[(TermRef, String)]) def distinctRefs(using Context): List[TermRef] =
val buf = new mutable.ListBuffer[TermRef]
var last = ""
for (ref, str) <- refs do
if last != str then
buf += ref
last = str
buf.toList

/** The best `n` references in `refs`, according to `compare`
* `compare` is a partial order. If there's a tie, we take elements
Expand Down