Fixes #1316: Remove JLine #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,14 +13,13 @@ trait InteractiveReader { | |||
| /** The current Scala REPL know how to do this flexibly. | |||
| */ | |||
| object InteractiveReader { | |||
| /** Create an interactive reader. Uses JLine if the | |||
| /** Create an interactive reader. Uses Ammonite if the | |||
| * library is available, but otherwise uses a | |||
| * SimpleReader. */ | |||
There was a problem hiding this comment.
Do we even need the SimpleReader anymore since the AmmoniteReader is always present in the dotty sources anyway?
There was a problem hiding this comment.
I agree that this try-catch can be removed.
Or, are you suggesting that removing SimpleReader entirely from Dotty?
There was a problem hiding this comment.
That's what I'm asking, I don't know :)
|
I've just rebased the branch against master to make my commit fast-forwardable. @smarter SimpleReader is still kept, but InteractiveReader doesn't call that based on the fact Ammonite is always there. |
|
/rebuild |
|
Can you rebase this to master, please? We'll merge it afterwards. |
Dotty uses ammonite.terminal since April (53bd25f) which replaces JLine. There is no reason to keep it anymore.
|
Merged, thank you and sorry for the delays! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotty uses ammonite.terminal since April (53bd25f) which replaces JLine.
There is no reason to keep it anymore.