Skip to content

Implement -Yno-predef and -Yno-imports #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2016

Conversation

jvican
Copy link
Member

@jvican jvican commented Jun 27, 2016

The following PR addresses #1294 and adds three unit tests.

@@ -1,14 +0,0 @@
import scala.tools.partest.ReplTest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to move this test to tests/run/ instead of deleting it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry, Intellij played dirty on me.

@jvican jvican force-pushed the implement-no-predef-no-import branch 2 times, most recently from 31784c4 to 12c0a1c Compare June 28, 2016 18:45
@jvican
Copy link
Member Author

jvican commented Jun 28, 2016

This is ready for review.

* Implement flags -Yno-predef and -Yno-imports

* Add unit tests for both
@jvican jvican force-pushed the implement-no-predef-no-import branch from 12c0a1c to 6684706 Compare June 28, 2016 22:09
@odersky
Copy link
Contributor

odersky commented Jul 6, 2016

LGTM

@nicolasstucki
Copy link
Contributor

You could change the commit message to Fix #1294: Implement -Yno-predef and -Yno-imports to follow the GitHub conventions.

@DarkDimius DarkDimius merged commit 18a1c20 into scala:master Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants