Multiple fixes for bin/dotc and bin/dotr
#1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New algorithm similar to proposal by @DarkDimius: 1. Bash script checks for existance of `$DOTTY_ROOT/.packages`, if not found - rebuilds all packages and places their full paths in the `.packages` file in the following order: - dotty-interfaces - dotty - dotty-tests 2. Checks if there are any files newer than those contained within `.packages` and if so - rebuilds that package 3. Runs Java with correct classpath setup
felixmulder
changed the title
felixmulder
changed the title
…olution by coursier
felixmulder
changed the title
bin/dotc
felixmulder
changed the title
bin/dotcbin/dotc and bin/dotr
felixmulder
force-pushed
the
fix/dotc-version#1321
branch
2 times, most recently
from
a37881f to
09bb08c
Compare
felixmulder
force-pushed
the
fix/dotc-version#1321
branch
from
09bb08c to
574681e
Compare
| source $DOTTY_ROOT/bin/common | ||
|
|
||
| # CLASS_PATH is derived from the DOTTY_ROOT and SCALA_LIBRARY_JAR | ||
| CLASS_PATH="-Xbootclasspath/a:.:$DOTTY_ROOT/target/scala-2.11/classes/:.:$SCALA_LIBRARY_JAR" |
There was a problem hiding this comment.
SCALA_BINARY_VERSION instead of 2.11.
|
Merging as it will get runner script working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple fixes for dotc script
Fix for repacking of
dotty-interfacesNew algorithm for package tracing similar to proposal by @DarkDimius:
$DOTTY_ROOT/.packages, if notfound - rebuilds all packages and places their full paths in the
.packagesfile in the following order:.packagesand if so - rebuilds that packageFixes #1321
Fixing coursier resolution
Coursier cannot resolve
"org.scala-sbt" % "interface" % version"- but it can find"com.typesafe" % "sbt-interface" % version".Fixes #1323
Address CI tests for dotc and dotr scripts
Implemented JUnit tests that check:
Fixes #1322