Prepare REPL for dotty-bridge #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
changed the title
initialCommands and cleanupCommands to REPL
felixmulder
force-pushed
the
topic/prepare-repl-for-bridge
branch
from
393ebe1 to
3e7c144
Compare
felixmulder
changed the title
felixmulder
force-pushed
the
topic/prepare-repl-for-bridge
branch
from
3e7c144 to
05d4322
Compare
| * field `value`. The value is then set via Java reflection. | ||
| * | ||
| * Example: We want to bind a value `List(1,2,3)` to identifier `list` from | ||
| * SBT. The bind method accomplishes this by creating the following: |
felixmulder
force-pushed
the
topic/prepare-repl-for-bridge
branch
from
05d4322 to
11b5a2a
Compare
| @@ -65,6 +65,9 @@ object REPL { | |||
| */ | |||
| val cleanupCommands: List[String] = Nil | |||
|
|
|||
| /** We also allow binding initial values */ | |||
There was a problem hiding this comment.
The description should not start with "We also allow ..." but just explains what bound values are and maybe give an example.
felixmulder
force-pushed
the
topic/prepare-repl-for-bridge
branch
2 times, most recently
from
fd5a5c6 to
7e1cdbf
Compare
|
@smarter: fixed your feedback 👍 |
| method.invoke(resObj, value) == null | ||
| } | ||
| } catch { | ||
| case _: Throwable => |
There was a problem hiding this comment.
import scala.util.control.NonFatal then case NonFatal(_) => instead?
|
Otherwise LGTM |
|
LGTM needs to be at the beginning of the line otherwise dotty-bot is unhappy :) |
felixmulder
force-pushed
the
topic/prepare-repl-for-bridge
branch
from
514feca to
5c29e0a
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preparing the REPL for #1293 being completed