Skip to content

change doc to recommend metals worksheet #12874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bishabosha
Copy link
Member

No description provided.

@bishabosha bishabosha force-pushed the docs-remove-worksheet branch from 0354bd4 to 7d625e1 Compare June 18, 2021 12:34
@smarter
Copy link
Member

smarter commented Jun 18, 2021

Seems like we could just delete that page and point to the metals documentation which will always be more up to date

@romanowski romanowski requested a review from tgodzik June 18, 2021 13:14
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smarter might be right that Metals worksheet docs should be always more up to date. Is the current state of the docs enough though? https://scalameta.org/metals/docs/editors/vscode.html#worksheets

A worksheet is a Scala file that is evaluated on save, and the result of each
expression is shown in a column to the right of your program. Worksheets are
A worksheet is a Scala file that is evaluated on save, powered
by [Scala Metals](https://scalameta.org/metals/), and the result of each
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
by [Scala Metals](https://scalameta.org/metals/), and the result of each
by [Scala Metals](https://scalameta.org/metals/) and [mdoc](https://scalameta.org/mdoc/), and the result of each

@@ -24,27 +25,20 @@ println("Hello, worksheets!")
456 + xyz
```

On top of the buffer, the message `Run this worksheet` appears. Click it to
evaluate the code of the worksheet. Each line of output is printed on the right
On top of the buffer, the message `Copy Worksheet Output` appears. Save the file to evaluate the code of the worksheet. Each line of output is printed on the right
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mention Copy Worksheet Output here, it can be mentioned additionally.

@bishabosha
Copy link
Member Author

I will close do to the other rewrite being proposed by scala/docs.scala-lang#2112

@bishabosha bishabosha closed this Jul 9, 2021
@bishabosha bishabosha deleted the docs-remove-worksheet branch September 10, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants