Skip to content

Fixed type name MirroredLabel in Type Class Derivation documentation #12856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Fixed type name MirroredLabel in Type Class Derivation documentation #12856

merged 1 commit into from
Jun 17, 2021

Conversation

KazuyaMiyashita
Copy link
Contributor

The correct name is MirroredLabel, but the documentation says MirroredLabels, so I fixed it.

I confirmed the name from the following source code.
https://github.com/lampepfl/dotty/blob/b1d576078b367e370716f2639800b9ebfc2d0826/library/src/scala/deriving/Mirror.scala#L11

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@KazuyaMiyashita
Copy link
Contributor Author

CI's Scala CLA failed, so I agreed and sent it to Lightbend's website.
I'm new to it, so please let me know if I have to do anything extra.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bishabosha bishabosha merged commit 816fae3 into scala:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants