Fixes to lambdalift that prevent memory leaks. #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectDependencies had incorrect handling of `Ident`s. If it had ever met an `Ident` to a symbol defined outside of current owner-chain(e.g. Predef.println) it would issue narrowTo(enclosingClass). This is very conservative and leads to memory leaks even in trivial lambdas. My lambda-lift-foo groes stronger :-)
Before there was an implicit assumption that static methods are only present on objects. This assumption is invalidated both by linker optimizations and the new fix to lambdalift.
DarkDimius
force-pushed
the
fix-lamda-lift
branch
from
935c770 to
c0da39f
Compare
See t5375.scala for details.
DarkDimius
force-pushed
the
fix-lamda-lift
branch
from
c0da39f to
4007910
Compare
|
@odersky please review. |
DarkDimius
force-pushed
the
fix-lamda-lift
branch
from
894dadb to
3b0cb48
Compare
| lock inside classloader. Unlike if it not static and is called through This(Test).foo, no lock is grabbed. | ||
|
|
||
| @DarkDimius | ||
| */ |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectDependencies had incorrect handling of
Idents. If it had ever metan
Identto a symbol defined outside of current owner-chain(e.g.Predef.println) it would issue narrowTo(enclosingClass).
This is very conservative and leads to memory leaks even in trivial lambdas.