sbt-dotty: Fix the binary suffix used for publishing #12452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler we publish is compiled with a non-bootstrapped compiler, so
its scalaBinaryVersion suffix is computed from the version number of the
non-bootstrapped compiler, for 3.0.0-RC3 this was
3.0.0-RC3-nonboostrapped
and we correctly return3.0.0-RC3
as abinary version, but for 3.0.0 this is
3.0.0-nonbootstrapped
for whichwe return again
3.0.0-nonbootstrapped
when we really want just3
.This is why we incorrectly published https://repo1.maven.org/maven2/org/scala-lang/scala3-compiler_3.0.0-nonbootstrapped/
Fixed by special-casing RCs and milestones which are the only special
suffixes that get their own binary suffix.
This fix is specific to the release-3.0.0 branch since the master branch
does not use sbt-dotty anymore (and will need its own fix to publish
3.0.1-RC1 correctly due to a different issue with how sbt computes
the suffix for
3.0.1-RC1-nonbootstrapped
).