Skip to content

Change order of operations in lub #12288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2021
Merged

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 30, 2021

Try to drop a supertype defore distributing into Or.

Fixes #12286 where a type variable was not instantiated to an OrType but was distributed into
the constituents instead.

Try to drop a supertype defore distributing into Or.

Fixes scala#12286 where a type variable was not instantiated to an OrType but was distributed into
the constituents instead.
@odersky
Copy link
Contributor Author

odersky commented Apr 30, 2021

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/12288/ to see the changes.

Benchmarks is based on merging with master (96d02e8)

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 98ecc10 into scala:master May 3, 2021
@liufengyun liufengyun deleted the fix-12286 branch May 3, 2021 16:36
@Kordyjan Kordyjan added this to the 3.0.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type inference issue when constraining on a union type
4 participants