Transform/nullarify #122
Merged
Transform/nullarify #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicit members are TermRefs that should have a prefix corresponding to the object of which they are a member. They used to have the ThisType of their owner before. `implicits2` provides a way to verify that the change works. It would be good to turn this into a more robust test at some point. But it's not high preiority, so I prefer no test to a fragile test.
Stable methods are introduced from getters by inserting () parameters. This change makes sure that adding () does not lose the members of an ExprType. Also, avoid spurious stale symbol errors in loadDenot. When something is not a SymDenotation, no use retrying in first phase; current would fail immediately.
Factored out denot transformer behavior where the we transform types in a uniform way into InfoTransformers.
Was an oversight before.
As a denotation need to take the symbol's info *as seen from the qualifier type*.
|
Review and sheparding by @DarkDimius please. @sjrd please review. |
| List(new PatternMatcher, | ||
| new LazyValTranformContext().transformer, | ||
| new Splitter), | ||
| List(new Nullarify, |
There was a problem hiding this comment.
What was a reason to create one more group?
There was a problem hiding this comment.
It's explained in class Nullarify:
override def runsAfterGroupsOf: Set[String] = Set("splitter")
// assumes idents and selects have symbols; interferes with splitter distribution
// that's why it's "after group".
|
That's all for me. |
Eliminates ExprTypes and PolyTypes over value types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support nullarify transform which inserts () as needed.