Workaround for ScalaMeter incorrect report path #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ScalaMeter issue is reported here: https://github.com/scalameter/scalameter/pull/163/files The issue exists both in v0.7 and v0.6. As dotty uses v0.6 now, use this workaround until we upgrate to a new version of ScalaMeter.
7 tasks
| @@ -239,7 +239,6 @@ object DottyBuild extends Build { | |||
|
|
|||
| libraryDependencies ++= Seq("com.storm-enroute" %% "scalameter" % "0.6" % Test, | |||
| "com.novocode" % "junit-interface" % "0.11"), | |||
| testFrameworks += new TestFramework("org.scalameter.ScalaMeterFramework"), | |||
There was a problem hiding this comment.
I removed this, because we never run dotty-bench/test, we use dotty-bench/test:run. The latter doesn't require the framework integration.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ScalaMeter issue is reported here:
https://github.com/scalameter/scalameter/pull/163/files
The issue exists both in v0.7 and v0.6. As dotty uses v0.6 now,
use this workaround until we upgrate to a new version of ScalaMeter.
With this PR, we no longer need to maintain two separate folders for reports.
Please review @DarkDimius .