Fix #11989: Remove dependency on find

[liufengyun]

Fix #11989: Remove dependency on find

[liufengyun]

@michelou Do you have suggestions for removing the dependency on find?

[smarter]

We could emit jars without the version number in the filename so we can refer to them with a fixed identifier.

[michelou]

@michelou Do you have suggestions for removing the dependency on find?

@liufengyun Let me start with two observations :

1. I'm not aware of any rule/constraint about the organisation of the jar files inside the directory <scala_home>/lib/.
   NB. Using ls instead of find means that we assume a flat organisation of the jar files.
2. As a hot reaction I would be inclined to say that a standard Unix distribution should include a command find.

So the point is to choose if we want to adapt the bash scripts to yet another user environment or we decide to introduce a requirement about the user environment.

Nevertheless I acknowledge the fact that people are working more and more with Docker images (which may provide very minimal sets of commands).

Side note : IMO it would worth looking at other JVM based tools (Java, Kotlin, etc.) regarding the jar file organisation.

Reminder :  ls only applies to the current working directory, while find applies to all files and subdirectories starting from the current working directory.

[liufengyun]

Thanks @michelou.

I'm not aware of any rule/constraint about the organisation of the jar files inside the directory <scala_home>/lib/

Yes, the directory is flat, which is a safe assumption in our case.

ls seems to work fine on Mac, but Linux is not happy.

[griggt]

Another option may be something like this, which eliminates both the subshell and the dependency on an external command like find/ ls / etc.

find_lib () {
  for lib in "$PROG_HOME"/lib/$1 ; do
    if [[ -e "$lib" ]]; then
      if [ -n "$CYGPATHCMD" ]; then
        "$CYGPATHCMD" -am "$lib"
      elif [[ $mingw ||  $msys ]]; then
        echo "$lib" | sed 's|/|\\\\|g'
      else
        echo "$lib"
      fi
      return
    fi
  done
}

[michelou]

Another option may be something like this, which eliminates both the subshell and the dependency on an external command like find/ ls / etc.

find_lib () {
  for lib in "$PROG_HOME"/lib/$1 ; do
    if [[ -e "$lib" ]]; then
      if [ -n "$CYGPATHCMD" ]; then
        "$CYGPATHCMD" -am "$lib"
      elif [[ $mingw ||  $msys ]]; then
        echo "$lib" | sed 's|/|\\\\|g'
      else
        echo "$lib"
      fi
      return
    fi
  done
}

On line 137, [[ -e "$lib" ]] may also include subdirectories. Why do you not use option -f (regular files only) here ?

[griggt]

Otherwise LGTM.