Skip to content

simple integration with jline #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2016
Merged

simple integration with jline #1204

merged 1 commit into from
Apr 6, 2016

Conversation

liufengyun
Copy link
Contributor

Fix #1084. Please review @odersky .

In this PR, I only added the basic functionality. Are there any specific features that are needed?

@odersky
Copy link
Contributor

odersky commented Apr 5, 2016

LGTM. For future commits, can you push to staging and make the pull request from there? We try to follow that schema to make it easier for several people to collaborate on a PR. Thanks!

@odersky
Copy link
Contributor

odersky commented Apr 5, 2016

One suggestion: Can we make it accept more than one version of jline? AFAIK 2.12 works fine, so do we need to demand that people upgrade?

@liufengyun
Copy link
Contributor Author

OK, I'll ask @DarkDimius to add me to the staging repo.

Regarding the version, I'm not sure if ivy will bind to 2.12 when 2.14 is available. The syntax [2.12,) seems to achieve what you want, but it's a bit weird in the Java world.

I agree let's restore it to be 2.12 for the moment.

@odersky odersky merged commit 4ca4fa1 into scala:master Apr 6, 2016
@liufengyun liufengyun deleted the jline branch April 6, 2016 08:26
@liufengyun
Copy link
Contributor Author

Thanks @odersky .

@som-snytt
Copy link
Contributor

I have a repl branch which incorporates scala repl bits at https://github.com/som-snytt/dotty/blob/topic/dopler/src/dotty/tools/dotc/repl/jline/Reader.scala

A goal is to have well-defined extension points in the repl package, and a supplied repl with fewer bells and whistles. That was for purpose of adding features, but I'll also check for jline-neutrality.

The day job is doing its annual release so I haven't had the time I'd like, but I'll try to contribute it soon.

Should that be a normal PR against dotty repo?

@smarter
Copy link
Member

smarter commented Apr 6, 2016

Should that be a normal PR against dotty repo?

Sure, why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants