community build: add play-json #12035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griggt
reviewed
Apr 8, 2021
|
all good now, thanks Tom |
griggt
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
On another note, ScalaTest 3.2.7 was recently released and now publishes for Scala.js on 3.0.0-RC2 (the first ScalaTest release with support for Scala.js on Dotty!), which hopefully means that some of the workarounds/shims in upstream play-json can be removed and the build updated to use Scala 3 versions of ScalaTest and ScalaCheck (it's currently using withDottyCompat).
I'm working on a PR now to update ScalaTest and friends in the community build.
|
@griggt thanks for the heads up — I don't have merge rights in the play-json repo, but I'll see if I can work with Dale to get the RC2 PR (and other queued PRs there) merged there and then look at simplifications |
nicolasstucki
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.