TASTY tests for src/dotty #1189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Now we just have to find out whether the failures are real or artificial. Note that it's not guaranteed that trees with types print the same before and after pickling. That would be too restrictive and low-level. Already now we paper over differences with the "homogenize" method in PlainPrinter. So we should classify any remaining failure into one of
|
|
@VladimirNik weren't those tests supposed to fail? |
|
@DarkDimius These tests are correct. On Monday I'll publish tests for files that are excluded from pickling in this pull request - I found simple examples for them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASTY tests for src/dotty are added.
In comments to tests there are files for which we have different representation before pickling and after unpickling.
Review by @odersky