Repl fixes and tests #1182
Merged
Repl fixes and tests #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke under the recent introduction of the JS backend, because now the context needs to be initialized before the platform can be selected. So invoking `doti` immediately gave an IllegalStateException. No big deal to fix, but it shows how sorely we are lacking REPL tests.
They printed as raw trees which confused the REPL when wrapping subsequent liens with them.
It messed up parsing of multi-line strings and did not seem to have a purpose. Error messages print fine without it.
It's used only in Resident, where it should be defined.
Central config class replaces mixture of parameters and fields. The fields were in part in the wrong class, where they could not easily be overridden.
|
rebased to master |
| required: String | ||
| buf += xs | ||
| ^ | ||
| <console>:11: error: type mismatch: |
There was a problem hiding this comment.
Why are two errors printed here?
Scalac reports only one.
There was a problem hiding this comment.
Not sure. I might depend on where the error is reported - same position in scalac, different ones in dotty. or some other artefact how += is compiled. But in any case dotc behaves like doti, so it's not a repl failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REPL broke in a recent merge. Nobody noticed because we don't have tests. This PR fixes the breakage and several other bugs and adds tests for the REPL.