Skip to content

Fix #11792 (Tuple.fromProduct doesn't handle Product0) #11793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2021
Merged

Fix #11792 (Tuple.fromProduct doesn't handle Product0) #11793

merged 1 commit into from
Mar 22, 2021

Conversation

sirthias
Copy link
Contributor

Trivial fix to #11792

@sirthias
Copy link
Contributor Author

CLA is now signed.

@nicolasstucki nicolasstucki linked an issue Mar 17, 2021 that may be closed by this pull request
Tuple.fromProduct doesn't handle Product0 #11792
Closed
@nicolasstucki
Copy link
Contributor

We should probably add a regression tests in tests/run/i11793.scala. The following code should do it.

case class Foo()
@main def Test: Unit = Tuple.fromProduct(Foo())

@sirthias could you add this?

@sirthias
Copy link
Contributor Author

Sure, will do.

@liufengyun liufengyun merged commit 75f7cb3 into scala:master Mar 22, 2021
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Tuple.fromProduct doesn't handle Product0
4 participants
@sirthias @nicolasstucki @liufengyun @Kordyjan