Skip to content

Make sbt-dotty compatible with sbt 1.5 #11758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Make sbt-dotty compatible with sbt 1.5 #11758

merged 2 commits into from
Mar 16, 2021

Conversation

adpi2
Copy link
Member

@adpi2 adpi2 commented Mar 15, 2021

Fix the doc task

@adpi2 adpi2 requested a review from smarter March 16, 2021 12:35
@adpi2 adpi2 marked this pull request as ready for review March 16, 2021 12:36
@SethTisue
Copy link
Member

I thought sbt-dotty wasn't needed anymore in sbt 1.5, so why make it compatible?

@adpi2
Copy link
Member Author

adpi2 commented Mar 16, 2021

It is a safety net and it enables a smooth and incremental transition. You can jump to sbt 1.5, check that everything is fine then remove sbt-dotty and check again.

Also it helps us to deal with the community-build since we don't need to remove sbt-dotty in every project by ourselves. For instance, in scodec sbt-dotty is added transitively by sbt-spiewak-sonatype, so we cannot remove it easily.

@adpi2 adpi2 merged commit 8b88918 into scala:master Mar 16, 2021
@adpi2 adpi2 deleted the sbt-dotty branch March 7, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants