Change signature of quoted.Type encoding #11608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
change-Type-encoding-signature
branch
3 times, most recently
from
0e07132 to
9366710
Compare
nicolasstucki
force-pushed
the
change-Type-encoding-signature
branch
from
9366710 to
9f1f1ef
Compare
liufengyun
approved these changes
Mar 7, 2021
| body.tpe match | ||
| case tp @ TypeRef(x: TermRef, _) if tp.symbol == defn.QuotedType_splice => | ||
| // Optimization: `quoted.Type.of[x.Underlying](quotes)` --> `x` | ||
| ref(x) |
There was a problem hiding this comment.
Here the body is not inspected. Is it possible that the body contains trees other than quoted.Type.of[x.Underlying](quotes)?
There was a problem hiding this comment.
No. This tree is generated on the QuotesAndSpliced typing class and its shape is kept as is. If We get something else it would be considered a bug and it would probably break more than this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids unnecessary closures in the generated code.
It will also help with meta-metaprogramming such as writing typeclass derivation for
ToExpr.Also updated internal documentation.