"sbt compile" uses non-boostrapped scaladoc #11506
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"sbt compile" is supposed to only compile non-bootstrapped projects (so we can rely on it working even if bootstrapping is broken while working on the compiler for example), but scaladoc is a bootstrapped project and it was part of the aggregate of the default project. Fixed by replacing it with `scaladoc-nonBootstrapped`. To compile all bootstrapped projects use `scala3-bootstrapped/compile` instead. Also make sure the dist project uses the correct scaladoc depending on whether it's bootstrapped or not.
nicolasstucki
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"sbt compile" is supposed to only compile non-bootstrapped projects (so
we can rely on it working even if bootstrapping is broken while working
on the compiler for example), but scaladoc is a bootstrapped project and
it was part of the aggregate of the default project. Fixed by replacing
it with
scaladoc-nonBootstrapped. To compile all bootstrapped projectsuse
scala3-bootstrapped/compileinstead.Also make sure the
distproject uses the correct scaladoc depending onwhether it's bootstrapped or not.