Fix #1146: Fix bug of ExpandSAMs with non-apply SAM methods. #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @odersky, as you have written most of |
sjrd
force-pushed
the
fix-non-jvm-sam-non-apply
branch
3 times, most recently
from
b4aa178 to
4b10e2b
Compare
Ah OK.
Done. |
When expanding a SAM, ExpandSAMs always used the name `apply` for the generated forwarder, instead of the name of the method which is abstract in the SAM type. This commit fixes this issue.
odersky
added a commit
that referenced
this pull request
Mar 7, 2016
Fix #1146: Fix bug of ExpandSAMs with non-apply SAM methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When expanding a SAM, ExpandSAMs always used the name
applyfor the generated forwarder, instead of the name of the method which is abstract in the SAM type. This commit fixes this issue.