Added monocle.

[dotbg]

No description provided.

[griggt]

It looks like this PR is accidentally reverting many of the other community build project submodules to older commit hashes, which is one of the reasons that the CI is failing.

To fix, you should probably run git submodule update --init and then git add those submodules to your commit so they are back on par with current master.

The CI will probably still fail after updating the submodules, but this will help isolate the actual changes needed to get this PR working.

[dotbg]

It looks like this PR is accidentally reverting many of the other community build project submodules to older commit hashes, which is one of the reasons that the CI is failing.

To fix, you should probably run git submodule update --init and then git add those submodules to your commit so they are back on par with current master.

The CI will probably still fail after updating the submodules, but this will help isolate the actual changes needed to get this PR working.

Thanks a lot. It will save me quite some time.
Is there any way to check the versions? I am not used to git submodules (yet)

[smarter]

This currently fail with:

Test dotty.communitybuild.CommunityBuildTestA.monocle failed: java.lang.RuntimeException: Publish command is not specified for shapeless

val shapeless needs to be modified to add sbtPublishCommand, probably with just = "publishLocal".
You can run this test locally from sbt with:

community-build/testOnly dotty.communitybuild.CommunityBuildTestA -- *monocle

[griggt]

I'm not sure publishing shapeless is going to fix much here, as the build is trying to use shapeless 2 and not shapeless 3.

Looking at the upstream Monocle upgrade-3-RC1 branch, it appears that only a subset of the subprojects are able to be built using Scala 3, not all of them, as is being attempted in this PR. (generic and example, the ones which use shapeless, do not appear to have been upgraded to Scala 3)

Also, I believe this PR originally had the submodule pointed to a commit hash on the upstream master branch (8eea9f478ae1aef613550fbb4647c636d8bcfd09) , rather than upgrade-3-RC1, but it seems like the Monocle submodule is now missing from the PR entirely.

[griggt]

Some suggestions:

To add the Monocle submodule:

cd community-build/community-projects/Monocle
git fetch
git checkout upgrade-3-RC1
cd ..
git add Monocle
git commit

To adjust what's being attempted to be built/tested: modify sbtTestCommand for monocle in projects.scala to something like:

    sbtTestCommand = "coreJVM/test; lawJVM/test; ... etc ...",

[dotbg]

I'm not sure publishing shapeless is going to fix much here, as the build is trying to use shapeless 2 and not shapeless 3.

Looking at the upstream Monocle upgrade-3-RC1 branch, it appears that only a subset of the subprojects are able to be built using Scala 3, not all of them, as is being attempted in this PR. (generic and example, the ones which use shapeless, do not appear to have been upgraded to Scala 3)

Also, I believe this PR originally had the submodule pointed to a commit hash on the upstream master branch (8eea9f478ae1aef613550fbb4647c636d8bcfd09) , rather than upgrade-3-RC1, but it seems like the Monocle submodule is now missing from the PR entirely.

I will check whether the most recent shapeless could be used. thanks for giving a hint

[b-studios]

Hey @dotbg, thanks for your contributions! What is the current status of this PR?

[dotbg]

Hi @b-studios, I have just updated the PR. I had few issues with the build before RC2.

[bishabosha]

Hi @dotbg is this PR ready to review?

[dotbg]

Hi @dotbg is this PR ready to review?

Hi. yes, it is ready to be reviewed