Fix check for unimplemented members in a concrete class #11439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
override-fix-2
branch
2 times, most recently
from
30f68d6 to
1922ff6
Compare
odersky
previously approved these changes
Feb 23, 2021
smarter
force-pushed
the
override-fix-2
branch
from
1922ff6 to
f796c95
Compare
Before this commit, this check was done using Type#matchesLoosely, which behaves differently from Denotation#matchesLoosely, in particular the latter requires matching signatures and the former does not, and because bridge generation at Erasure relies on denotation matching, we could end up with unimplemented members at runtime. Fixed by switching to denotation matching which should now be used uniformly everywhere we check for overrides. This commit also improves the error message of this check to list where the abstract member and non-matching concrete members come from, since this can be difficult to figure out in a complex hierarchy. Fixes scala#10666.
This was already fixed by scala#11361.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, this check was done using Type#matchesLoosely, which
behaves differently from Denotation#matchesLoosely, in particular the
latter requires matching signatures and the former does not, and because
bridge generation at Erasure relies on denotation matching, we could end
up with unimplemented members at runtime. Fixed by switching to
denotation matching which should now be used uniformly everywhere we
check for overrides.
This commit also improves the error message of this check to list where
the abstract member and non-matching concrete members come from, since
this can be difficult to figure out in a complex hierarchy.
Fixes #10666.