Optimization: don't run override checks between Java definitions #11432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/11432/ to see the changes. Benchmarks is based on merging with master (e79ca04) |
smarter
force-pushed
the
opt-java-override-checks
branch
from
13e272e to
6d43c88
Compare
This is the same optimization I implemented in Scala 2 a while ago: scala/scala@ba53545 We never run RefChecks on a Java class, but we can run it on a Scala class which inherits from a Java class B which itself inherits from another Java class A. In that case we don't need to check that members of B correctly override members of A.
odersky
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization: don't run override checks between Java definitions
This is the same optimization I implemented in Scala 2 a while ago:
scala/scala@ba53545
We never run RefChecks on a Java class, but we can run it on a Scala
class which inherits from a Java class B which itself inherits from
another Java class A. In that case we don't need to check that members
of B correctly override members of A.