Do not choose implicits that are ambiguous references #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, implicit_ambiguous_ref.scala failed to compile because the implict search returned `x`, we now always try to typecheck a reference to an identifier before returning it from the implicit search.
smarter
force-pushed
the
fix/implicit_amb_refs
branch
from
ec52017 to
8f34919
Compare
|
/rebuild |
1 similar comment
|
/rebuild |
|
both partests failed. Does not look like false failure to me: |
|
Oh, I missed those, the failures I saw were due to download failures. |
|
Closing since this was the wrong approach and #1142 needs to be take care of first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, implicit_ambiguous_ref.scala failed to compile
because the implict search returned
x, we now always try to typechecka reference to an identifier before returning it from the implicit search.