Fix #11276: Scala.js: Take JUnit tests from superclasses/traits into account. #11382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into account.
The Scala 2 code uses
owner.info.members.filter(m => m.isMethod && m.hasAnnotation(annot))
for the equivalent operation.
The code in Scala 3 used `decls` instead of `members`, which is
clearly incorrect. This commit fixes the discrepancy.
This was tested manually by making sure that
> sjsJUnitTests/testOnly org.scalajs.testsuite.javalib.util.ArrayListTest
runs 40 tests, and not just 1. It is not clear how to write
automated tests for this fix.
|
Tentatively assigning this to the RC1 milestone. Assuming the CI passes, this should be a no-brainer. Without this fix, there are potentially a lot of tests in the wild that are silently ignored. |
nicolasstucki
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scala 2 code uses
for the equivalent operation.
The code in Scala 3 used
declsinstead ofmembers, which isclearly incorrect. This commit fixes the discrepancy.
This was tested manually by making sure that
runs 40 tests, and not just 1. It is not clear how to write
automated tests for this fix.