Skip to content

Scala3doc: improve member lookup #11302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

abgruszecki
Copy link
Contributor

No description provided.

@abgruszecki abgruszecki force-pushed the scala3doc/improve-member-lookup branch from b8e9312 to a29d83d Compare February 3, 2021 15:59
@abgruszecki abgruszecki marked this pull request as ready for review February 3, 2021 16:54
@abgruszecki
Copy link
Contributor Author

@romanowski this fixes the vast majority of link lookup warnings in stdlib - we got down from 1k to, I think, 80 warnings. I created separate issues for the other problems:

val matched = syms.find(matches)
// val syms0 = syms.toList
// val matched0 = syms0.find(matches)
// if matched0.isEmpty then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugging leftover?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally left it commented out, it's going to be useful when debugging again.

@abgruszecki abgruszecki merged commit 67f3db6 into scala:master Feb 4, 2021
@abgruszecki abgruszecki deleted the scala3doc/improve-member-lookup branch February 4, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants