Scala3doc: Add icons to symbols on page #11268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanowski
requested changes
Feb 1, 2021
| @@ -613,6 +613,55 @@ footer .pull-right { | |||
| position: relative; | |||
| } | |||
|
|
|||
| .header { | |||
There was a problem hiding this comment.
This adds a padding to lists of members as well
|
Can we also include icons in navigation? If so can we make a |
pikinier20
force-pushed
the
scala3doc/symbol-icons
branch
from
9a8659d to
8d14395
Compare
pikinier20
force-pushed
the
scala3doc/symbol-icons
branch
from
8d14395 to
1518b38
Compare
BarkingBad
approved these changes
Feb 8, 2021
| @@ -158,7 +167,7 @@ class HtmlRenderer(rootPackage: Member, val members: Map[DRI, Member])(using ctx | |||
| val attr = if expanded || isSelected then Seq(cls := "expanded") else Nil | |||
| (isSelected || expanded) -> div(attr)( | |||
| linkHtml(expanded), | |||
| span(), | |||
| span(cls := "ar"), | |||
There was a problem hiding this comment.
What ar name comes from? Maybe we would like to name it more meangingful?
There was a problem hiding this comment.
arrow. We will be adding tons of this to all pages so we want to keep it as short as possible
romanowski
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.